fix(make): improve targets and prerequisites to avoid running a recipe unnecessarily #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardocardoso
previously approved these changes
May 15, 2023
jenstroeger
force-pushed
the
makefile-improve-deps
branch
from
45ab465
to
2a4ac41
Compare
behnazh
reviewed
Jul 13, 2023
| @@ -162,14 +169,18 @@ check-mypy: | |||
| pre-commit run mypy --all-files | |||
| check-actionlint: | |||
| pre-commit run actionlint --all-files | |||
| check: | |||
| check: .venv/checked-on | |||
| .venv/checked-on: $(PACKAGE_DEPS) | |||
There was a problem hiding this comment.
Looks like we are introducing back pre-commit running on staged files only (instead of all files)?
There was a problem hiding this comment.
PACKAGE_DEPS contains all current Python files in the src/package/ folder, and if any of those changes since make last touched .venv/checked-on then we run the recipe again. Whether they’re staged or not shouldn’t make a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.