feat: the Pull Request action now verifies signed commits #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenstroeger
force-pushed
the
check-signed-commits-on-pr
branch
from
74a059a
to
ba02a3e
Compare
|
This blog and this gist show how to sign commits from an Action using the python-package-template/.github/workflows/release.yaml Lines 55 to 60 in 25c486b And here’s an interesting blog using a third-party tool Gitsign. I think we’ll still have to do a little more digging for better approaches 🤔 |
Open
behnazh
reviewed
Oct 6, 2022
| for sha in `git log --format=format:%H $PR_BASE_REF..$PR_HEAD_REF` | ||
| do | ||
| echo "Checking signature for commit $sha" | ||
| git verify-commit $sha |
There was a problem hiding this comment.
How will git verify-commit have access to the commit author's public key?
There was a problem hiding this comment.
That’s part of our discussion in issue #332.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat related to issue commitizen-tools/commitizen#575, but using plain bash + git instead of commitizen.