TeamStatus: Fix status posting for PRs and commits #217
Conversation
Due to some misasumptions about the ways the tfs-plugin can trigger a job, there was a too early (and duplicated) check that caused calling TeamStatus.addStatus with a null-pointer. This also fixes the status posting for commits. Fixes: JENKINS-54569
|
could someone please re-trigger the build? The build failed due to jenkins remoting problems. |
This is required for a Code pushed event to work with a generic build trigger.
|
Okay, apparently the Event payloads look different if you select "Trigger generic build" instead of "Trigger git build", the last commit handles that behavior. |
|
+1 Could you merge it ? |
|
@sterchelen I do not have write access to this repo, so I cannot. The last commit I got merged by opening a VSTS (now azure devops) ticket and waiting a few months. |
|
@Mrflow Ok. There is not workaround to get back status working ? |
|
@sterchelen You can build it yourself and install your build on your Jenkins instance. That's what we are doing here as well (including a few other not-yet-merged PRs). |
|
Is Microsoft the owner of this plugin?
…On Mon, 18 Feb 2019, 10:19 Florian Bäuerle, ***@***.***> wrote:
@sterchelen <https://github.com/sterchelen> You can build it yourself and
install your build on your Jenkins instance. That's what we are doing here
as well (including a few other not-yet-merged PRs).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQfcadNnC_qhiVWI2ejYaQ-UONX0HsToks5vOnAPgaJpZM4Y5h0C>
.
|
|
I cannot say that for sure, but to me it very much looks like it is. |
|
Hey @Mrflow, do you mind sharing your method of managing the plugin? |
|
@gokhansengun you basically just have to clone the repo and run The result is a file that you can upload on your Jenkins installation as a plugin. |
|
That makes a ton of sence @Mrflow, thanks 👍 Just had enough time not touching Java for years :) |
|
Will they integrate at some point? |
|
@ricardf No, I think this plugin seems to be abandoned as Microsoft nowadays offers its own CI solution. You can also integrate Jenkins builds through this solution, i.e. by wrapping the Jenkins build with an azure devops build. Scales badly though (configuration-wise and also it will block a build node for each build). The only way I ever was able to get changes merged was contacting the Microsoft support, they might poke the people responsible for this. But even then it took me months to get changes merged. |
Due to some misasumptions about the ways the tfs-plugin can trigger a
job, there was a too early (and duplicated) check that caused calling
TeamStatus.addStatus with a null-pointer.
This also fixes the status posting for commits.
Fixes: JENKINS-54569