Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IgnoredInternalClasses #736

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 26, 2024

@jglick jglick added the bug label Aug 26, 2024
@Override public boolean ignore(Class<?> clazz) {
return WithScriptDescribable.class.isAssignableFrom(clazz) ||
CredentialsBindingHandler.class.isAssignableFrom(clazz) ||
clazz.getName().startsWith("org.jenkinsci.plugins.pipeline.modeldefinition.");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various classes in src/main/groovy/. Was not sure how to classify these more cleanly.

@jglick jglick requested a review from a team August 26, 2024 23:39
@jglick jglick marked this pull request as ready for review August 27, 2024 23:08
@jglick jglick enabled auto-merge August 27, 2024 23:08
@jglick jglick merged commit bb34b2e into jenkinsci:master Aug 28, 2024
17 checks passed
@jglick jglick deleted the InternalCalls branch August 28, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants