Fix error when downloading multiple jdbc drivers #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The databaseDriverUrl config property is a string potentially defining a comma-separated list of urls.
It is splitted and iterated on every single url, download the jdbc driver jar and detect a proper file name for it (among other things).
Unfortunately the filename detection throws a StringIndexOutOfBoundsException when the databaseDriverUrl config property has multiple urls (i.e. https://jdbc.postgresql.org/download/postgresql-42.2.20.jar,https://repo1.maven.org/maven2/com/oracle/database/jdbc/ojdbc11/21.1.0.0/ojdbc11-21.1.0.0.jar).
It probably meant to use the substring from the last index of the "/" separator to the end of the url,
but it uses the position from the whole databaseDriverUrl property (unsplitted).
This fix proposes to get the last index of the "/" separator from the currently processed driver url
in order to compute the jar file name, so trying to follow the intention of the author.