Migrate 'Liquibase Runner' plugin docs from wiki to GitHub #3782 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
requested changes
Dec 6, 2020
There was a problem hiding this comment.
Thanks @Fargk ! pom.xml also needs an update so that it points to a right location. Added a few extra comments/proposals
README.adoc
Outdated
| * https://www.jenkins.io/security/advisory/2020-09-23/#SECURITY-1885[Stored XSS vulnerability] | ||
| -- | ||
|
|
||
| [.conf-macro .output-inline]#Provides https://www.liquibase.org/[Liquibase] build steps that evaluate liquibase changesets.# |
There was a problem hiding this comment.
Would be nice to cleanup leftover macros
There was a problem hiding this comment.
Hi @oleg-nenashev ,
Not sure that need to update URL because it has already pointed on new Jenkins site.
README.adoc
Outdated
Comment on lines
25
to
30
| [frame="none",grid="none",width="100%",cols="25%,25%,25%,25%",] | ||
| |=== | ||
| |image:src/docs/images/dbdoc.png[image,width=300,height=149] | ||
| |image:src/docs/images/changeset-detail.png[image,width=300,height=134] | ||
| |image:src/docs/images/changeset-listing.png[image,width=300,height=138] | ||
| |image:src/docs/images/changeset-summary.png[image,width=300,height=194] |
There was a problem hiding this comment.
Renders as 2x2 to make them bigger? Too small now IMHO
There was a problem hiding this comment.
I just have made as in the original confluence page.
But changed to 2x2
|
Hi @oleg-nenashev, |
Fargk
force-pushed
the
migrate_liquibase_runner_readme
branch
5 times, most recently
from
934c523 to
90f1a24
Compare
Fargk
force-pushed
the
migrate_liquibase_runner_readme
branch
from
90f1a24 to
f26d76a
Compare
|
@Fargk changing URL from Wiki to GitHub repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Issue #3782