[JENKINS-74992] Avoid NPE on informers #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found out when working on a CloudBees proprietary feature that `KubernetesCloud#readResolve` is not always called on deserialization. I think this will not happen in OSS, but let's stay on the safe side and initialize the field before using it.
amuniz
commented
Dec 19, 2024
Comment on lines
+53
to
+55
| String message = c.getMessage(); | ||
| String formatted = | ||
| String.format("%n\tPod [%s][%s] %s", phase, c.getReason(), message != null ? message : "No message"); |
There was a problem hiding this comment.
Unrelated, but I just saw it during testing and thought it would be ok to slip it here :)
Vlatombe
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out when working on a CloudBees proprietary feature that
KubernetesCloud#readResolveis not always called on deserialization. I think this will not happen in OSS, but let's stay on the safe side and initialize the field before using it.Following up #1627
Testing done
Submitter checklist