Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-74950 - Improve the K8s Maven sample to run in resources limited environments #1626

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jgarciacloudbees
Copy link
Contributor

JENKINS-74950 - Improve the K8s Maven sample to run in resources limited environments

The sample "kubernetes-maven.groovy" does not specify any request or limit.

In resource limited environments it could fail due to OOM events.

We have reproduced this issue by running it in a pod with memoty limited to 256Mi.

We have modified the current sample to add requests and limits for memory.

spec:
  containers:
  - resources:
      requests:
        memory: "256Mi"
      limits:
        memory: "512Mi" 

Testing done

Manual test have been performed to confirm the script works properly in limited environments that was failing with the original sample.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes --> Does not apply
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jgarciacloudbees jgarciacloudbees requested a review from a team as a code owner December 4, 2024 17:03
@jglick jglick added the enhancement Improvements label Dec 4, 2024
@jglick jglick merged commit a756e4b into jenkinsci:master Dec 4, 2024
9 checks passed
@jgarciacloudbees jgarciacloudbees deleted the JENKINS-74950 branch December 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants