-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JENKINS-72894 - Adding support to more than 1000 repositories #773
base: master
Are you sure you want to change the base?
JENKINS-72894 - Adding support to more than 1000 repositories #773
Conversation
addressed (I am not reviewing code changes at this time)
|
||
// Only the first 1000 search results are available | ||
if (ghRepositorySearchBuilder.list().getTotalCount() > 1000) { | ||
return org.listRepositories(100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me like this is ignoring all the search settings above.
There is also redundant code in these two new methods that can be reduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, the query above only returns the first 1000 records. This is a github limitation.
The query also returns the number of existing records and this value is used to make a decision.
Description
Adding support to more than 1000 repositories. See
JENKINS-72894 for further information.
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify