-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always show the GitHub endpoint selection #401
base: master
Are you sure you want to change the base?
Conversation
I checked the source and app credential rendering, but not sure in what page is GitHubSCMNavigator used? |
<f:entry title="${%API endpoint}" field="apiUri"> | ||
<f:select/> | ||
</f:entry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this drop down will also include github.com
if the endpoint list is empty. Or did that change at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not include github.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlossg Ping? |
Today if you add a new GitHub App credential there is no option to select a GitHub enterprise installation. You must know that you need to go to settings - manage jenkins and add the endpoint. |
so users are aware that they must add a new endpoint in configuration Standardize the docs for apiUri
Description
so users are aware that they must add a new endpoint in configiuration
Standardize the docs for apiUri
Submitter checklist
Reviewer checklist
Documentation changes
Users/aliases to notify