Additional features #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message with Build Parameters
[x] Support for chat message on success [x] Build started by and build params in the chat message
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| String rootUrl = Hudson.getInstance().getRootUrl(); | ||
| String buildLink = (rootUrl == null) ? null : rootUrl + build.getUrl(); | ||
| if(buildLink != null) msg.setLink(buildLink); | ||
|
|
||
| msg.setSubject(build.getProject().getName() + " #" + buildNo + " " + buildResult.getHumanResult().toUpperCase()); |
There was a problem hiding this comment.
Why .toUpperCase()? I would prefer leaving this as it was.
|
All in all, these seem like features that could be added to the plugin. Please see the inline comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Support for chat message on success
[x] Build started by and build params in the chat message
[x] Cleaned up the chat message