Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-69868] Avoid deserialization of anonymous classes #61

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

chriskloe
Copy link
Contributor

Avoid deserialization of anonymous classes. Found a hint in the console log and followed the advice: https://www.jenkins.io/doc/developer/extensibility/serialization-of-anonymous-classes/

Affected issue: JENKINS-69868

Avoid deserialization of anonymous classes. Found a hint in the console log and followed the advice: https://www.jenkins.io/doc/developer/extensibility/serialization-of-anonymous-classes/
@MarkEWaite MarkEWaite changed the title Update AbstractCvs.java Avoid deserialization of anonymous classes Oct 15, 2022
@MarkEWaite MarkEWaite changed the title Avoid deserialization of anonymous classes [JENKINS-69868] Avoid deserialization of anonymous classes Oct 15, 2022
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks.

@gounthar
Copy link
Contributor

The failure is due to a network or machine connection problem, not to the code itself.

@MarkEWaite
Copy link
Contributor

Thanks for the contribution @chriskloe . Apologies that it took so long to merge.

@chriskloe
Copy link
Contributor Author

No need to apologize, there has not been a release for some time. Even my first fix is not released yet. On my server I'm working with a locally built version. Maybe enabling incremental builds will help here.
At the moment it looks like I am creating a lot confusion with my commits. I am not yet used to git, github and the git plugin in eclipse.
Today's commits were not intended to go to this PR but instead to individual new ones.
I'm very sorry for that!

@MarkEWaite
Copy link
Contributor

@chriskloe the CVS plugin could really use a new maintainer. Are you still using the plugin? If so, are you interested in adopting the plugin?

Active users of a plugin are often the best maintainers, since they are most likely to release new versions as needed and are most likely to merge pull requests and verify them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants