Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jQuery target element for tooltip to work correctly in AbstractNameValueHeader/rowHeader.jelly #156

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Nov 8, 2024

Problem

  • The original jQuery snippet was searching for an element with an ID pattern build-parameters-trigger-.... However, this ID was missing from the DOM, causing the functionality to break.

Solution

  • Rename the target element to #build-parameters-... which is the ID of the container in the build-card body that displays the build parameters. This is more intuitive as it will show a tooltip for params when hovering over params vs hovering over the title/header.

Screenshot 2024-11-11 at 4 42 59 PM

ref:

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan requested a review from a team as a code owner November 8, 2024 20:29
@shlomomdahan shlomomdahan changed the title Add missing ID for tooltip to work correctly in AbstractNameValueHeader/rowHeader.jelly Fix jQuery target element for tooltip to work correctly in AbstractNameValueHeader/rowHeader.jelly Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant