remove redundant span, add attributes to trigger span

jenkinsci · Nov 8, 2024 · cfae875 · cfae875
1 parent 16ccf5b
commit cfae875
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.../com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/.../com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,8 +1,7 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-        const paramsElement = document.querySelector('.bpp-trigger-pipeline-parameterized-params');
-        const href = paramsElement.dataset.fillDialogHref;
-        const title = paramsElement.dataset.fillDialogTitle;
+        const href = element.dataset.fillDialogHref;
+        const title = element.dataset.fillDialogTitle;
         buildPipeline.fillDialog(href, title);
     });
 });

diff --git a/...n/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/...n/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -63,8 +63,7 @@
         <j:if test="${hasBuildPermission}">
             <div class="icon-container">
             <j:if test="${from.isProjectParameterized()}">
-                <span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" />
-                <span class="bpp-trigger-pipeline-parameterized pointer">
+                <span class="bpp-trigger-pipeline-parameterized pointer" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters">
                     <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
                 </span>