-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple attempt at adding song listing to artist page #6410
base: master
Are you sure you want to change the base?
Conversation
Cloudflare Pages deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint doesn't pass. Please fix all ESLint issues.
Lint suggestions Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing review
Updating equality
Quality Gate passedIssues Measures |
This adds a song list within the artist detail.
It solves the probem where you can't remember a song name, so you have to jump album to album looking for it and if it's not part of a known album it's impossible to find without manally scanning the songs list ( impossible for a large library ) or being able to guess at the song name well enough in search.
I understand this may not be ideal for the following reasons:
I welcome your feedback/commentary regardless of outcome.
This was a few hours getting setup/familiar with the codebase and was done as simply as reasonable to accomplish the goal.
Changes
Issues
No issues resolved, feature