Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple attempt at adding song listing to artist page #6410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

theevilapplepie
Copy link

This adds a song list within the artist detail.

It solves the probem where you can't remember a song name, so you have to jump album to album looking for it and if it's not part of a known album it's impossible to find without manally scanning the songs list ( impossible for a large library ) or being able to guess at the song name well enough in search.

I understand this may not be ideal for the following reasons:

  • There is no pagination
  • I'm not confident the "Special Feaure" isn't used somehow by MusicArtist but I couldn't find anywhere it is
  • The presentation does not match the new Vue frontend

I welcome your feedback/commentary regardless of outcome.
This was a few hours getting setup/familiar with the codebase and was done as simply as reasonable to accomplish the goal.

Changes

  • Updated listview to support adding album for audio types
  • Updated itemDetails/index.js to reuse "Special Feature" for the "MusicArtist" item type for presenting songs by the artist

Issues
No issues resolved, feature

@theevilapplepie theevilapplepie requested a review from a team as a code owner December 27, 2024 05:49
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 27, 2024

Cloudflare Pages deployment

Latest commit 1b5cbc8
Status ✅ Deployed!
Preview URL https://8d4fac9d.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/components/listview/listview.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
src/controllers/itemDetails/index.js Outdated Show resolved Hide resolved
Lint suggestions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Author

@theevilapplepie theevilapplepie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants