Show username validation error messages #6399
Open
+46
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any errors returned by the API when submitting edits to a user caused the loading spinner to stay on screen. This hides the spinner and makes the error message visible to the user
Show a descriptive message when the username input doesn't match a modified version of the regex used by the backend
Cloudflare Pages deployment
|
dmitrylyzo
reviewed
Dec 18, 2024
| @@ -318,6 +327,7 @@ const UserEdit = () => { | |||
| type='text' | |||
| id='txtUserName' | |||
| label='LabelName' | |||
| validator={{ pattern: '^([\\w \\-\'._@+]*)([\\w\\-\'._@+])([\\w \\-\'._@+]*)$', errMessage: 'Username must not be empty and contain only numbers, letters, spaces, or the following symbols -\'._@+' }} | |||
There was a problem hiding this comment.
The text of the error message should be moved to en-us.json and globalize.translate should be used.
There was a problem hiding this comment.
Is that the way to add new phrases for globalization? Is there anything else I need to do for Weblate?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Closes #6384