Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate logs to React #6393

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Migrate logs to React #6393

wants to merge 17 commits into from

Conversation

viown
Copy link
Member

@viown viown commented Dec 17, 2024

Changes
Migrates the dashboard logs page to React + TS SDK

Issues

@viown viown added the cleanup Cleanup of legacy code or code smells label Dec 17, 2024
@viown viown requested a review from a team as a code owner December 17, 2024 12:56
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 17, 2024

Cloudflare Pages deployment

Latest commit 1dede0c
Status ✅ Deployed!
Preview URL https://583e78f7.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

src/apps/dashboard/routes/logs.tsx Outdated Show resolved Hide resolved
src/apps/dashboard/routes/logs.tsx Outdated Show resolved Hide resolved
</Stack>
</Form>
<div className='serverLogs readOnlyContent'>
<div className='paperList'>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this to a mui also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated look:
image
Let me know if I should change anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use a <List> and <ListItem> instead of cards?

src/apps/dashboard/routes/logs/index.tsx Show resolved Hide resolved
src/apps/dashboard/features/logs/api/useLogOptions.ts Outdated Show resolved Hide resolved
src/apps/dashboard/features/logs/api/useLogEntries.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants