Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent opus more than 2 channels being remuxed on Safari #6373

Open
wants to merge 2 commits into
base: release-10.10.z
Choose a base branch
from

Conversation

gnattu
Copy link
Member

@gnattu gnattu commented Dec 11, 2024

Safari only supports stereo Opus, which requires a similar workaround as we are applying on WebOS for FLAC.

This would currently force downmix 5.1 opus to stereo. After jellyfin/jellyfin#13209 landed in server the server will fallback to transcode 5.1 aac when source is 5.1 opus.

Changes

Issues

Safari only supports stereo Opus, which requires a similar workaround as we are applying on WebOS for FLAC.
@gnattu gnattu requested a review from a team as a code owner December 11, 2024 06:53
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 11, 2024

Cloudflare Pages deployment

Latest commit 8f7974d
Status ✅ Deployed!
Preview URL https://16894472.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small remark.

src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants