Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirm dialog when deleting server #6366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flebel9
Copy link

@flebel9 flebel9 commented Dec 7, 2024

Changes
Add confirm dialog when deleting a server to prevent accidental deletion

Images
delete_select
delete_confirm

@flebel9 flebel9 requested a review from a team as a code owner December 7, 2024 11:31
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 7, 2024

Cloudflare Pages deployment

Latest commit 534c7b6
Status ✅ Deployed!
Preview URL https://5aefbfa4.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/controllers/session/selectServer/index.js Outdated Show resolved Hide resolved
src/controllers/session/selectServer/index.js Outdated Show resolved Hide resolved
@flebel9 flebel9 force-pushed the delete-server-confirm branch from 96ca6f4 to 534c7b6 Compare December 7, 2024 11:37
Copy link

sonarqubecloud bot commented Dec 7, 2024

@dmitrylyzo dmitrylyzo added enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants