Add playlist editing #6184
Add playlist editing #6184
Conversation
|
I was able to toggle the public access setting of an existing playlist, which worked as expected. |
| import('./playlisteditor/playlisteditor').then(({ default: PlaylistEditor }) => { | ||
| const playlistEditor = new PlaylistEditor(); | ||
| playlistEditor.show({ | ||
| id: itemId, | ||
| serverId | ||
| }).then(getResolveFunction(resolve, id, true), getResolveFunction(resolve, id)); | ||
| }); |
There was a problem hiding this comment.
Isn't this more readable without chaining thens?
There was a problem hiding this comment.
I'm not sure I follow what you are suggesting 😅
|
Seems to work fine in my testing with a non-admin user. Only UX issue I could find is when you use a space as name it allows you to save that, not a major issue but might be good to check for that (e.g. I would also argue that the delete button should always be lower then the edit button. |
|
The context menu needs a total overhaul so I'm not touching that here beyond adding the new entry 😅 |
Cloudflare Pages deployment
|
thornbill
force-pushed
the
playlist-editor
branch
from
08ab261 to
e1a00a5
Compare
thornbill
force-pushed
the
playlist-editor
branch
from
e1a00a5 to
a37388b
Compare
|
Changes
Currently this allows changing the playlist name and public access but not user level access controls
Issues
Part of #4698