Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item ID is used as MediaSourceId #6395

Open
Kevinjil opened this issue Dec 17, 2024 · 0 comments · May be fixed by #6396
Open

Item ID is used as MediaSourceId #6395

Kevinjil opened this issue Dec 17, 2024 · 0 comments · May be fixed by #6396
Labels
playback This PR or issue mainly concerns playback

Comments

@Kevinjil
Copy link

Describe The Bug
I am debugging playback issues of my plugin implementing the IChannel interface and I noticed that the call sent to the /Items/<uid>/PlaybackInfo now contains a key MediaSourceId in the JSON, which equals the uid of the URL. With this key set, the JF server returns no compatible streams. When fetching from the 10.9 webclient (with a JF 10.10 server), this key is missing and the server does report streams and playback starts.

Looking at the JF source, there is some filtering if this key is set. It appears that this key should not be set to the item.Id value.

Looking at the change history, it looks like an accidental || item.Id was introduced in #6112 to query for the item, perhaps not realising it is later used in the query later on for server-side filtering. This was partially fixed by #6166 for Live TV by not setting this variable in that case.

Media Information
N/A

Screenshots
N/A

System (please complete the following information):

  • Platform: Linux
  • Browser: Firefox
  • Jellyfin Version: 10.10.3

Additional Context
N/A

@Kevinjil Kevinjil added the playback This PR or issue mainly concerns playback label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playback This PR or issue mainly concerns playback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant