refactor: use generator function for generic worker #2525
+72
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
ferferga
force-pushed
the
improve-generic-worker
branch
from
15dc971 to
f285dc1
Compare
ferferga
force-pushed
the
improve-generic-worker
branch
from
f285dc1 to
46a43e5
Compare
This spawns the worker only when needed, avoiding the extra memory usage of keeping it running all the time Also properly release the worker in JVirtual Signed-off-by: Fernando Fernández <[email protected]>
ferferga
force-pushed
the
improve-generic-worker
branch
from
46a43e5 to
a58c6a8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spawns the worker only when needed, avoiding the extra memory usage of keeping it running all the time
Also properly release the worker in JVirtual
TODO: Playback manager doesn't shuffle correctly with this