Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Samsung Smart Hub Preview Integration #319

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

morpheus133
Copy link
Contributor

@morpheus133 morpheus133 commented Dec 8, 2024

This pull request introduces support for Samsung Smart Hub Preview integration, enabling Jellifyn users to leverage the native Smart Hub capabilities for better app discoverability and user experience.

Key Features:

- Smart Hub Preview Support:

  • Added integration with Samsung's Smart Hub Preview API.
  • Supports displaying rich content previews and deep linking directly from the Smart Hub interface.

-Default Configuration:

  • Next Up: Displays 2 items.
  • Continue Watching: Displays 4 items.

Testing:

  • Fully tested and verified on Tizen 4 (emulator and TV).
  • Tested on Tizen 5 emulator.

Resolves:
This implementation addresses and resolves issue #318.

Work in Progress:

  • I am looking for additional testers, especially on newer tizen versions

  • Decisions are still pending on:

    • Optimal number of elements for different sections.
    • Additional sections that could be useful for various content types.

Next Steps:

  • Feedback on current implementation and configurations.

  • Suggestions for additional sections or adjustments to the item limits.

  • More testing on a wider range of devices and scenarios.

Reference:
For more details on Smart Hub Preview capabilities, refer to the Samsung Developer Guide.

Thank you for reviewing this PR! I look forward to feedback and suggestions to enhance this feature further.

emulator-x86_64_UrptYPG3wg

@morpheus133
Copy link
Contributor Author

Rewrite the first version, now it works with all emulator. (And I hope with all tv.)

@G-eos
Copy link

G-eos commented Dec 17, 2024

Ci, why closing this PR ? This was a good idea !

@morpheus133 morpheus133 reopened this Dec 17, 2024
@morpheus133
Copy link
Contributor Author

morpheus133 commented Dec 17, 2024

I dont want to close it.
I dont know how it happens.

@matjako
Copy link

matjako commented Dec 22, 2024

I would maybe switch the layout to continue watching first and next up second but anyhow, when can we expect the merge? This looks to me like a great upgrade to the app.

@dmitrylyzo
Copy link
Collaborator

I still haven't taken the time to review the PR, but after a quick look I believe it could lead to showing unwanted content to children. TV is a sharing device, so we have to take that into consideration.

If I understand correctly, it works with the last logged in user. At the moment, we don't perform auto logout (close session) when we exit the app. Thus, when we do, this feature will stop working.

@matjako
Copy link

matjako commented Dec 22, 2024

No children in my house so I did not even think about that. As far as I know, some other streaming apps do not log out and show the last watched show/movie, but I understand your concern.

@morpheus133
Copy link
Contributor Author

At the moment, it update the smart view 3 - times:

  • When app start and somebody logged in.
  • Every 10 minutes. ( This is added because usually we never exit, just change to other app.)
  • When we exit.

I think all other apps (Netflix, Disney, etc) use the last logged in user data to show up.

But we can add some settings when and what to show at the smart view.

Any suggestions?

@morpheus133
Copy link
Contributor Author

morpheus133 commented Dec 22, 2024

No children in my house so I did not even think about that.

I have, but they see only public posters what they can see every where else. (Movie theater, on street, at TV)
If login is set for parent account they can't play it.

@morpheus133
Copy link
Contributor Author

morpheus133 commented Dec 28, 2024

Jellyfin Android TV has the same feature:
https://github.com/jellyfin/jellyfin-androidtv/blob/master/app/src/main/java/org/jellyfin/androidtv/integration/LeanbackChannelWorker.kt
As I see here also use the currently authenticated user to get the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Samsung Smart Hub Preview integration
4 participants