Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish tray app as net471 for x64 #122

Closed
wants to merge 1 commit into from
Closed

Conversation

crobibero
Copy link
Member

No description provided.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually built the tray app with the CI command (dotnet publish -c Release -r win-x64 -f net471 --no-self-contained) and copied the published files to the Jellyfin install directory (10.9.2). Unfortunately the server now refused to start because some of the DLL files are incompatible.

If we really want to lower the .NET framework target for the tray app we must redo the directory structure (e.g. tray app and server in separate folders).

Additionally you should add the artifacts folder to the gitignore.

@anthonylavado
Copy link
Member

.NET 4.7.2 is what it was before, so I think I'll be okay to roll back to that version. It seems from 4.7.2 to 4.7.1 won't net us many more supported platforms, and it will safely grab the users on Windows Server 2019 that we have making issues.

@anthonylavado anthonylavado deleted the publish-net471 branch June 5, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants