Update typescript-eslint to v8 #846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
commented
Dec 4, 2024
| @@ -23,7 +23,6 @@ module.exports = { | |||
| }], | |||
|
|
|||
| '@typescript-eslint/consistent-type-imports': ['error'], | |||
| '@typescript-eslint/type-annotation-spacing': ['error'], | |||
There was a problem hiding this comment.
If this rule is still required then the ESLint Stylistic plugin will have to be added.
Happy to do that as part of this PR if this rule is essential.
There was a problem hiding this comment.
Please add it... we will likely want additional rules from it in the future
This rule was removed from typescript-eslint in v8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating this separately instead of combining the updates in #688 will make updating to ESLint 9 a bit easier.
This will conflict with #845 since that also updates these plugins, but to a different version. I'll rebase this if that one's merged first.