Fix: Resolved issue for switching audio tracks

[F0x1]

Fix: Prevent Video Playback Issues on Roku When Switching Audio Tracks

Changes

Added logic to stop the LoadMetaDataTask before reusing it to prevent potential conflicts that could cause playback issues.
Improved comments to clarify the configuration and execution flow of the metadata task.
Context
This fixes a bug encountered on Roku devices where switching audio tracks during playback caused the video to stop functioning. The issue was due to conflicts arising from the reuse of the LoadMetaDataTask without proper stopping and resetting.

Issues

Fixes #2059

Notes for Reviewers

• I would originally get "Error During Playback" when attempting to switch audio tracks before the bug fix

[jimdogx]

@F0x1 Thanks for looking in to this. Reviewing the code though, I think I see the issue. Any chance you can test your setup with the original code (without your changes) and only change one line:

comment out (or remove) this line in onAudioIndexChange():

m.LoadMetaDataTask.selectedSubtitleIndex = m.top.SelectedSubtitle

(it's line 349 in the original code for me)

[F0x1]

@jimdogx it looks like that fixes it as well not sure why though

[jimdogx]

@jimdogx it looks like that fixes it as well not sure why though

I unfortunately don't have this issue with my setup. However, after I saw how you fixed it, I realized it's most likely because of a race condition. Removing that line is probably the correct fix.

I would also remove the following line from onSubtitleChange() also:

m.LoadMetaDataTask.selectedAudioStreamIndex = m.top.audioIndex

If you update your PR to just removing those two lines I can approve it 👍

Oh, also, can you base your change off of 2.2.z instead of Master. This is a bug fix, so it should go in the 2.2.z branch for the next release. 🎉