Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop trying to force mp3 on live tv streams #2047

Closed
wants to merge 1 commit into from
Closed

Stop trying to force mp3 on live tv streams #2047

wants to merge 1 commit into from

Conversation

cewert
Copy link
Member

@cewert cewert commented Nov 13, 2024 •
edited
Loading

Changes

  • Only force mp3 when stream is not live tv

Issues

Fixes #2043
Ref #1963

@cewert cewert added the bug-fix This fixes a bug. label Nov 13, 2024
@cewert cewert requested a review from a team as a code owner November 13, 2024 13:32
@cewert cewert changed the title Bump build version Stop trying to force mp3 on live tv streams Nov 13, 2024
@cewert cewert mentioned this pull request Nov 13, 2024
Closed
jimdogx
jimdogx requested changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@jimdogx jimdogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this is a bigger fix than we had hoped. See comments in #2043

Should probably close / abandon this PR and we'll work on the much larger fix.

@cewert cewert closed this Nov 17, 2024
@cewert cewert deleted the fix-aac-livetv branch November 17, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimdogx jimdogx jimdogx requested changes

Assignees
No one assigned
Labels
bug-fix This fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cewert @jimdogx