Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AV1 support - Fix direct streaming with no sound #2044

Merged
merged 2 commits into from
Nov 13, 2024
+3 −18
Merged

Improve AV1 support - Fix direct streaming with no sound #2044

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f00038a
stop adding h264 to codec string twice
cewert Nov 12, 2024
a79c259
force a full transcode for AV1 instead of direct streaming
cewert Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions source/utils/deviceCapabilities.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,19 +211,6 @@ function getTranscodingProfiles() as object
'
' AVC / h264 / MPEG4 AVC
for each container in transcodingContainers
if di.CanDecodeVideo({ Codec: "h264", Container: container }).Result
if container = "mp4"
' check for codec string before adding it
if mp4VideoCodecs.Instr(0, ",h264") = -1
mp4VideoCodecs = mp4VideoCodecs + ",h264"
end if
else if container = "ts"
' check for codec string before adding it
if tsVideoCodecs.Instr(0, ",h264") = -1
tsVideoCodecs = tsVideoCodecs + ",h264"
end if
end if
end if
if di.CanDecodeVideo({ Codec: "mpeg4 avc", Container: container }).Result
if container = "mp4"
' check for codec string before adding it
Expand Down Expand Up @@ -301,11 +288,9 @@ function getTranscodingProfiles() as object
end if

' AV1
' CanDecodeVideo() returns false for AV1 when the container is provided
' Manually add AV1 to the mp4VideoCodecs list if support is detected
if di.CanDecodeVideo({ Codec: "av1" }).Result
mp4VideoCodecs = mp4VideoCodecs + ",av1"
end if
' direct streaming av1 is not supported on roku
' force a full transcode by omitting av1 from the transcoding profile
' https://community.roku.com/t5/Roku-Developer-Program/HLS-fMP4-No-Audio/td-p/607399

' AUDIO CODECS
for each container in transcodingContainers
Expand Down
Loading