New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash and Update video player meta data #1964

Merged

cewert merged 2 commits into jellyfin:2.1.z from cewert:maxvideodecoderesolution

Oct 4, 2024

Member

cewert commented Oct 4, 2024 •

edited

Loading

Changes

Validate data to prevent crash introduced in Fix AAC codec support for real. Transcode Main and HE-AAC #1963
Add video length
Add MaxVideoDecodeResolution
- https://developer.roku.com/en-ca/docs/references/scenegraph/media-playback-nodes/video.md#miscellaneous-fields
- Ref buffer loop exception:Reserve size (61100564) exceeds max_allocation (46976204) #1554 There is a chance this fixes some bugs and I see no downside to setting this to the currently playing video's width and height
Add StreamFormat (mp4 or mkv)
- The docs specifically talk about mp4 needing this setting but doesn't mention why? Adding this can only help IMO https://developer.roku.com/en-ca/docs/developer-program/core-concepts/playing-videos.md#mpeg-4-playback
- https://developer.roku.com/en-ca/docs/developer-program/getting-started/architecture/content-metadata.md#playback-configuration-attributes

cewert added 2 commits

October 4, 2024 11:07


          Use the current video dimensions to set MaxVideoDecodeResolution and …

050bdde

…update video length and streamformat


          validate data to prevent crash

42bb0eb

cewert added the bug-fix label

cewert requested a review from a team as a code owner

October 4, 2024 15:33

cewert changed the title ~~Update video player meta data~~ Prevent crash and Update video player meta data

jimdogx approved these changes

View reviewed changes

cewert merged commit d17a8d9 into jellyfin:2.1.z

13 checks passed

cewert deleted the maxvideodecoderesolution branch

October 4, 2024 20:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix