Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on TV show page when shuffling #1954

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Oct 1, 2024

Caused by loss of connection to the api server

Comes from roku.com crash log:

m                roAssociativeArray refcnt=2 count:9 
global           Interface:ifGloba$1 Local Variables: 
   file/line: pkg:/components/tvshows/TVShowDetails.brs(165) 
#0  Function onshuffleepisodedataloaded() As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/tvshows/TVShowDetails.brs(165)

which points to this line after running build-prod on 2.1.4:

m.global.queueManager.callFunc("set", m.getShuffleEpisodesTask.data.items)

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Oct 1, 2024
@cewert cewert requested a review from a team as a code owner October 1, 2024 18:01
@cewert cewert merged commit 5e98ce2 into jellyfin:2.1.z Oct 2, 2024
13 checks passed
@cewert cewert deleted the fix-series-shuffle-crash branch October 2, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants