Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Played Indicator to Series #1906

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

K-Money
Copy link
Contributor

@K-Money K-Money commented Aug 9, 2024

Changes

Add played indicator to series if series is played.

@K-Money K-Money requested a review from a team as a code owner August 9, 2024 06:20
@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed in 15 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Sep 9, 2024
@jellyfin-bot jellyfin-bot removed the stale This issue/PR has gone stale. label Sep 15, 2024
@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Sep 25, 2024
@cewert cewert merged commit 295786c into jellyfin:master Sep 25, 2024
5 checks passed
@K-Money
Copy link
Contributor Author

K-Money commented Oct 6, 2024

Hi @cewert,
Apologies if this is an incredibly noob question, but it shows this pull request was merged to master on Sep 25, but I don't see it listed in any of the change logs for the last couple releases that have come out since then, even though newer changes are shown. Is that normal? Am I looking in the wrong place? Or did I miss a step in the pull request process that I should have completed?

It's my first pull request and I'm trying to figure out the proper way to do it so I can submit more in the future. Thanks for any insight you can provide and for all the work you do on this project!

@cewert
Copy link
Member

cewert commented Oct 6, 2024

You did everything correctly!

The last couple releases have been bugfix releases which only contain bugs fixed in the production app. (When only the last digit goes up that's a bugfix release e.g. 2.1.5 -> 2.1.6

Since this PR added something that we didn't have before, we are considering it a new feature (the PR's label doesn't say "bug-fix) so it didn't make it in the bugfix releases but instead will be in the next feature release e.g. 2.2.0. We don't have a date for 2.2.0 but hopefully soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants