Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home page crash (2) #1886

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix home page crash (2) #1886

merged 1 commit into from
Jul 31, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 31, 2024

Prevent crash by validating node ref and recreating as needed. Comes from roku.com crash log:

Invalid value for left-side of expression. (runtime error &he4) in pkg:/components/home/HomeItem.brs(48) 
Backtrace: 
#0  Function itemcontentchanged() As Voi$1 file/line: pkg:/components/home/HomeItem.brs(49) 
Local Variables: 
global           Interface:ifGloba$1 m                roAssociativeArray refcnt=2 count:14 
itemdata         roSGNode:HomeData refcnt=1 
localglobal      roSGNode:Node refcnt=2 
playedindicatorleftposition <uninitialized> 
extraprefix      <uninitialized> 
textextra        <uninitialized>

which points to this line after running build-prod on 2.1.2:

m.backdrop.width = itemData.imageWidth

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 31, 2024
@cewert cewert requested a review from a team as a code owner July 31, 2024 12:30
@cewert cewert merged commit 329a796 into jellyfin:2.1.z Jul 31, 2024
13 checks passed
@cewert cewert deleted the fix-homeitem-crash2 branch July 31, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants