Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Whats New popup and update lastRunVersion on prod #1882

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 31, 2024

This allows devs and testers who have already sideloaded that version to still get the whats new popup when prod updates.

A downside may be testing registry migrations since lastRunVersion won't update on dev deploy

Changes

  • Only show Whats New popup and update lastRunVersion on prod

@cewert cewert added the dev-improvement This improves the dev experience in some way. label Jul 31, 2024
@cewert cewert requested a review from a team as a code owner July 31, 2024 02:03
@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed in 15 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Aug 31, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has been closed because it has been inactive for 45 days. You may submit a new pull request if desired.

@cewert cewert removed the stale This issue/PR has gone stale. label Sep 25, 2024
@cewert cewert reopened this Sep 25, 2024
source/Main.bs Outdated Show resolved Hide resolved
@cewert cewert merged commit dc9bb5a into jellyfin:master Oct 17, 2024
5 checks passed
@cewert cewert deleted the whatsnew-dev branch October 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-improvement This improves the dev experience in some way.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants