Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded API call and fix LoadVideoContentTask crash (2) #1875

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 28, 2024

Remove unneeded API call and fix app crash when AboutMe() returns invalid. Comes from roku.com crash log:

Crashlog:

transcodingreasons <uninitialized> 
trydirectplay    <uninitialized> 
fully_external   <uninitialized> 
defaultsubtitleindex <uninitialized> 
currentitem      <uninitialized> 
playbackposition <uninitialized> 
user             Invali$1 logoimageexists  Boolean val:fals$1 logolookupid     roString refcnt=1 val:"8a084671e25509fef760fa5362257c67" 
videotype        roString (2.1 was String) refcnt=1 val:"episode" 
subtitle_idx     roInt refcnt=1 val:-2 (&hFFFFFFFE) 
meta             roSGNode:TVEpisodeData refcnt=1 
m                roAssociativeArray refcnt=4 count:3 
global           Interface:ifGloba$1 forcetranscoding Boolean val:fals$1 audio_stream_idx Integer val:0 (&h0) 
mediasourceid    Invali$1 video            roAssociativeArray refcnt=2 count:7 
Local Variables: 
   file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(47) 
#0  Function loaditems() As Voi$1 file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(55) 
#1  Function loaditems_videoplayer(id As String, mediasourceid As Dynamic, audio_stream_idx As Integer, forcetranscoding As Boolean) As Dynami$1 file/line: pkg:/components/ItemGrid/LoadVideoContentTask.brs(107) 
#2  Function loaditems_addvideocontent(video As Object, mediasourceid As Dynamic, audio_stream_idx As Integer, forcetranscoding As Boolean) As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/ItemGrid/LoadVideoContentTask.brs(107)

which points to this line after running build-prod on 2.1.2:

if user.Configuration.EnableNextEpisodeAutoPlay

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 28, 2024
@cewert cewert requested a review from a team as a code owner July 28, 2024 03:19
@cewert cewert merged commit 454217a into jellyfin:2.1.z Aug 2, 2024
13 checks passed
@cewert cewert deleted the fix-loadvideocontenttask-crash3 branch August 2, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants