Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExtrasItem crash #1872

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix ExtrasItem crash #1872

merged 2 commits into from
Aug 2, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 28, 2024

Prevent crash by validating node refs and recreating as needed. Comes from roku.com crash log:

Invalid value for left-side of expression. (runtime error &he4) in pkg:/components/extras/ExtrasItem.brs(10) 
Backtrace: 
#0  Function showcontent() As Voi$1 file/line: pkg:/components/extras/ExtrasItem.brs(11) 
Local Variables: 
global           Interface:ifGloba$1 m                roAssociativeArray refcnt=2 count:3 
cont             roSGNode:ExtrasData refcnt=1 
BRIGHTSCRIPT: ERROR: roUrlTransfer.GetToString: Sync-wait interrupted: pkg:/source/api/baserequest.brs(75)

which points to this line after running build-prod on 2.1.2:

m.name.text = cont.labelText

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 28, 2024
@cewert cewert requested a review from a team as a code owner July 28, 2024 02:02
@cewert cewert merged commit 49d8193 into jellyfin:2.1.z Aug 2, 2024
13 checks passed
@cewert cewert deleted the fix-extrasitem-crash branch October 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants