Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to hide community and critical ratings for movies #1756

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

photonconvergence
Copy link
Contributor

Changes

Add setting to Library->Movies to hide community and critical ratings from Movie Presentation view and Movie details view.
Add translation strings for setting.

Issues

Fixes: #1290

@photonconvergence photonconvergence requested a review from a team as a code owner March 22, 2024 04:01
@photonconvergence photonconvergence changed the title Add option to hide community and critical ratings for movies Add setting to hide community and critical ratings for movies Mar 22, 2024
components/ItemGrid/MovieLibraryView.bs Outdated Show resolved Hide resolved
components/movies/MovieDetails.bs Outdated Show resolved Hide resolved
@cewert cewert added feature A new feature that currently doesn't exist. new-setting A new user setting. and removed feature A new feature that currently doesn't exist. labels Apr 7, 2024
components/movies/MovieDetails.xml Outdated Show resolved Hide resolved
components/movies/MovieDetails.xml Outdated Show resolved Hide resolved
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works great!

There's a couple of little things with how the setting is worded then we can get this merged.

settings/settings.json Outdated Show resolved Hide resolved
settings/settings.json Outdated Show resolved Hide resolved
settings/settings.json Outdated Show resolved Hide resolved
@photonconvergence
Copy link
Contributor Author

photonconvergence commented Apr 27, 2024

Given the latest feedback, a good followup for this would be a refactor of the same setting for TV Shows.

components/ItemGrid/MovieLibraryView.bs Outdated Show resolved Hide resolved
components/movies/MovieDetails.bs Outdated Show resolved Hide resolved
locale/en_US/translations.ts Outdated Show resolved Hide resolved
locale/en_US/translations.ts Outdated Show resolved Hide resolved
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and your patience! 🙏

@cewert cewert merged commit 9fe5f5f into jellyfin:master Apr 28, 2024
10 of 11 checks passed
@photonconvergence photonconvergence deleted the hide-movie-ratings branch May 4, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-setting A new user setting.
Projects
Development

Successfully merging this pull request may close these issues.

Add setting to disable community ratings for movies
2 participants