Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create method to navigate to Previous/Next items in playlist #1703

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Create method to navigate to Previous/Next items in playlist #1703

merged 2 commits into from
Feb 23, 2024

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Feb 13, 2024

Changes

Adds previous and next item buttons to OSD, allowing users to navigate through playlists (including behind the scenes playlists, such as TV show seasons)

Also links previous and next buttons in audio player to navigate through items if audio is part of the playlist.

Demo

https://social.linux.pizza/@tgpo/111512062495955328

Multi-part phases

  1. Core functionality to navigate through playlists ⬅️ This PR
  2. Add UI element showing the title of the next and previous items

@1hitsong 1hitsong added the feature A new feature that currently doesn't exist. label Feb 13, 2024
@1hitsong 1hitsong requested a review from a team as a code owner February 13, 2024 03:52
@cewert
Copy link
Member

cewert commented Feb 14, 2024

Since you labeled this as multi-part, can you give a quick run down of each part you have planned?

Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Tested with Movies, Videos, Episodes, and Music Videos. Are there more possible types?

IMO when skipping to the next item it would make sense to mark the current item as watched but the behavior in this PR matches the web client 🤷

@1hitsong
Copy link
Member Author

Works as expected. Tested with Movies, Videos, Episodes, and Music Videos. Are there more possible types?

Playlists also support mixing in audio and audiobooks, so they are also supported within this PR.

@cewert
Copy link
Member

cewert commented Feb 22, 2024

I forgot I also tested with Audio files. Since audiobooks are basically the same thing I think that covers it 😄

Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed something. When hitting previous/next while playing an album, the GUI is paused while the next track is loaded. When hitting previous/next while playing a song in a mixed playlist, most of the GUI goes black while loading the next song. This creates a jarring effect when the next song is from the same album.

@1hitsong
Copy link
Member Author

@cewert See if that's better for you. I added a check so if you're currently playing audio and the item you're navigating to is also audio, it keeps you in the audio player instead of backing out and back in to the player.

@1hitsong 1hitsong merged commit 0c59c2a into jellyfin:master Feb 23, 2024
11 checks passed
@1hitsong 1hitsong deleted the OSD-Item-Navigation branch February 23, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature that currently doesn't exist. multi-part
Projects
Development

Successfully merging this pull request may close these issues.

2 participants