-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default subtitle track selection #1604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes #1571. Is there anything else that needs tested with the copied functions?
The big things are ensuring the selection paths work as expected, and that the language check works. I had to update the language selection code because it was not selecting any subtitle by default because my SubtitleLanguagePreference is set to "Any Language" on the server, which equals "" in code. This caused the language check to never pass. |
I just tried this and it didn't work unfortunately. Watching a movie with a forced subtitled track results in the following:
If I manually toggle subtitles off and then back on it will display the subtitles. However, if I then go to another movie with standard English not forced subtitles those will be displayed as well despite the subtitle selection dialog indicating subtitles are off. Clicking None, even if it is already selected and then clicking ok turns subtitles back off. |
Can you post a screenshot of your subtitle settings on the server? Specifically the 1st 3 items, Preferred subtitle language, Subtitle mode, and Burn subtitles. |
Changes
Add code to determine which subtitle to select and enable by default - without the user needing to manually select it.
Several functions were copied from subtitles.bs. Once we're fully on the new global queue player, this file should no longer be needed.
Modify selection logic to be:
Issues
Fixes #1571
Fixes #850