Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix what's new popup and show it for each user if enabled #1556

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Dec 6, 2023

A recent PR broke the whats new popup so that it will show every login if enabled and the whats new user setting had a bug where it would only be respected if that user was the first to login after an upgrade. This fixes both of those issues.

Changes

  • During 2.0.0 migration, set each users LastRunVersion to the app's LastRunVersion i.e. 1.6.6
  • Use the user's lastrunversion when checking if we should show the whats new popup after login
  • After login, update the users lastrunversion in the registry if it does not equal the apps current version
  • Display the current app version in the whats new popup title
  • Use the current app version as the filename for the whatsnew json data
    • This would allow us in the future to display a whats new popup for every version the user has missed

@cewert cewert added the bug-fix This fixes a bug. label Dec 6, 2023
@cewert cewert requested a review from a team as a code owner December 6, 2023 15:48
@1hitsong
Copy link
Member

1hitsong commented Dec 6, 2023

I did a clean install of 2.0.0 and the popup didn't show.

@1hitsong 1hitsong merged commit 0670ae3 into jellyfin:unstable Dec 7, 2023
9 checks passed
@cewert cewert deleted the fix-whatsnew branch January 14, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants