Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watched checkmark to Movies, Collections, TV Shows, Season list. Remove API generated checkmark #1547

Merged
merged 7 commits into from
Jan 2, 2024
Merged

Add watched checkmark to Movies, Collections, TV Shows, Season list. Remove API generated checkmark #1547

merged 7 commits into from
Jan 2, 2024

Conversation

photonconvergence
Copy link
Contributor

@photonconvergence photonconvergence commented Dec 3, 2023

Adds watched checkmark to most library views.
Aligns unwatched episode count rectangle in Season list view.
Removes the last API generated watched checkmark (Season list view)

Fixes:
#312
#402
#1027

Inspired by:
#922
#1223

@photonconvergence photonconvergence requested a review from a team as a code owner December 3, 2023 01:37
@photonconvergence photonconvergence changed the title Add watched checkmark to Movies, Collections, TV Shows, Season list Add watched checkmark to Movies, Collections, TV Shows, Season list. Remove API generated checkmark Dec 3, 2023
components/ItemGrid/GridItem.bs Outdated Show resolved Hide resolved
components/ItemGrid/GridItemSmall.bs Outdated Show resolved Hide resolved
components/ListPoster.bs Outdated Show resolved Hide resolved
@cewert cewert changed the base branch from unstable to master December 14, 2023 15:09
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Jan 2, 2024
@cewert cewert merged commit 11f8b60 into jellyfin:master Jan 2, 2024
13 checks passed
@photonconvergence photonconvergence deleted the griditem-watched-checkmark branch January 6, 2024 03:55
@chibiconsulting
Copy link

There should be a user configuration setting to control the color & visibility of the new feature.

Having the ability to select the color of the unwatched counter and the color and/or visibility of the watched checkbox would be a great user experience improvement. With the current implementation, the library views are just a sea of blue boxes.

New settings should be in: Settings / User Interface / Libraries / General

Although could also be in: Settings / User Interface / Libraries / TV Shows as there is already a setting there to "Disable Unwatched Episodes" there; however, this should be a more global solution.

In either case, the settings would be .. / Unwatched Overlay and .. / Watched Overlay with the options being various colors or no display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants