Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alpha menu - refactor, bugfix, and QOL updates #1539

Merged
merged 10 commits into from
Jul 12, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Nov 27, 2023

This converts the alpha menu to use the correct styling for vars, it moves the mic icon inside the alpha node, fixes an edge case bug, and adds some quality of life improvements.

Changes

  • Refactor Alpha.bs and all files that use it to use lowerCamelCase for all var names
  • Move the mic icon from ItemGrid, MovieLibraryView, and MusicLibraryView and put it inside the Alpha component. Also removes the mic text completely
    • Moved the mic icon and mic text to the overhang to match the tvguide page (except for music library which hides the overhang)
    • The tvguide/itemgrid was the only thing using the mic text (and reusing the mic icon). I am now creating the mic icon and text nodes as needed for the livetv guide view.
  • Convert mic icon from a Button to a Poster node
  • Keep focus on alpha menu after selecting a letter
    • EDIT: I'm keeping focus on alpha menu now whenever it is active no matter what. Including after using the voice filter option
  • When a user selects the same letter that is already focused, remove the current filter instead of doing nothing
  • Move logic to show mic icon into Alpha.bs
  • When using the voice search/filter feature, if the users search is for a single character, select the corresponding option on the alphamenu i.e. saying "Z" will select "Z" on the alhpamenu. saying 3 will select "#" etc.

Issues

Fixes #1297
Fixes #1526
Fixes #1527
Fixes #1528

Note: there was one thing I tried to fix but couldn't figure out how:

  • When the alpha menu is not focused, there is a wide "focused" overlay that shows up on top of it although it is hard to see with the naked eye. Here is a screenshot after first load of the movie library (notice the overlay around #)
    image

@cewert cewert requested a review from a team as a code owner November 27, 2023 15:48
@cewert cewert changed the title update alpha - refactor, bugfix, and QOL updates Update Alpha menu - refactor, bugfix, and QOL updates Nov 27, 2023
@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Nov 30, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@cewert cewert changed the base branch from unstable to master December 14, 2023 15:07
@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Dec 18, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Jan 8, 2024
@1hitsong 1hitsong removed the stale This issue/PR has gone stale. label Jan 11, 2024
@1hitsong
Copy link
Member

In my Movie library, in Presentation view, I clicked a letter and it threw an error on line 737 m.spinner.visible = true

image

@cewert
Copy link
Member Author

cewert commented Jan 14, 2024

hah so the reason I missed that crash was because of my movie library being bugged (it would load using the itemgrid instead of the movie specific grid). Apparently that fixed itself recently because I can reproduce this crash. Great timing 😆

@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Feb 4, 2024
@jellyfin-bot jellyfin-bot added merge-conflict This PR has a merge conflict and removed stale This issue/PR has gone stale. labels Feb 5, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@1hitsong
Copy link
Member

This also likely fixes #1297

@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label Mar 13, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired.

@cewert cewert reopened this Apr 7, 2024
@cewert cewert marked this pull request as draft April 7, 2024 15:42
@cewert cewert mentioned this pull request Apr 7, 2024
@cewert cewert linked an issue Apr 7, 2024 that may be closed by this pull request
@cewert cewert removed the stale This issue/PR has gone stale. label Apr 11, 2024
@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Apr 11, 2024
@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Apr 11, 2024
@cewert cewert marked this pull request as ready for review April 11, 2024 14:35
@jellyfin-bot
Copy link
Contributor

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@jellyfin-bot jellyfin-bot added the stale This issue/PR has gone stale. label May 3, 2024
@jellyfin-bot
Copy link
Contributor

This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired.

@cewert cewert reopened this Jul 12, 2024
@cewert cewert removed the stale This issue/PR has gone stale. label Jul 12, 2024
@cewert cewert merged commit 77dd380 into jellyfin:master Jul 12, 2024
25 of 26 checks passed
@cewert cewert deleted the update-alpha-menu branch July 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
5 participants