-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alpha menu - refactor, bugfix, and QOL updates #1539
Conversation
…r will move the alphamenu focus to the corresponding letter
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
hah so the reason I missed that crash was because of my movie library being bugged (it would load using the itemgrid instead of the movie specific grid). Apparently that fixed itself recently because I can reproduce this crash. Great timing 😆 |
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
This also likely fixes #1297 |
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired. |
This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity. |
This pull request has been closed because it has been inactive for 28 days. You may submit a new pull request if desired. |
This converts the alpha menu to use the correct styling for vars, it moves the mic icon inside the alpha node, fixes an edge case bug, and adds some quality of life improvements.
Changes
Alpha.bs
and all files that use it to use lowerCamelCase for all var namesItemGrid
,MovieLibraryView
, andMusicLibraryView
and put it inside the Alpha component.Also removes the mic text completelyButton
to aPoster
nodeAlpha.bs
Issues
Fixes #1297
Fixes #1526
Fixes #1527
Fixes #1528
Note: there was one thing I tried to fix but couldn't figure out how: