Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set credentials on bsconfig.json instead of the VSCode user configuration #1537

Closed
wants to merge 3 commits into from
Closed

Set credentials on bsconfig.json instead of the VSCode user configuration #1537

wants to merge 3 commits into from

Conversation

arturocuya
Copy link
Contributor

Changes

  1. Rename bsconfig.json to bsconfig-base.json
  2. Create a new bsconfig.json that extends from the base configuration, plus the credentials.
  3. Add the new bsconfig.json to .gitignore so that the file is unique for each developer. Added a bsconfig-sample.json as an example of this file for new developers.
  4. Update the instructions in the launch.json config to indicate that the credentials now go inbsconfig.json

@arturocuya arturocuya requested a review from a team as a code owner November 26, 2023 17:23
@cewert
Copy link
Member

cewert commented Nov 26, 2023

Hi @arturocuya thanks for the PR! 👋

I know you were talking about setting up RTA before, does RTA need the credentials in the bsconfig file? Whats the motivation behind the changes? The main reason I ask is because I would much prefer to use the vscode settings for credentials when writing code and testing. This way I can use those same credentials when running a repo in another folder without having to copy over my bsconfig with credentials.

The build npm script would still need to be updated btw. I believe that's why the CI is failing.

@arturocuya
Copy link
Contributor Author

Thanks for the context. I found a different way to solve the problem. Closing...

@arturocuya arturocuya closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants