Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix movie and tv show library quickplay support #1531

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Nov 22, 2023

Apparently my local server is bugged because when I coded quick play, movie and tv show libraries came through as collectionFolders but now they come through as userViews. This PR moves the quick play logic into a function and calls the fucntion from both paths.

Tested and working with my local and the stable demo server (a buggy and non-buggy server)

@cewert cewert added the bug-fix This fixes a bug. label Nov 22, 2023
@cewert cewert requested a review from a team as a code owner November 22, 2023 19:15
@1hitsong
Copy link
Member

1hitsong commented Nov 24, 2023

I went to my recording library, which has 1 season, which only has 1 video. I pressed Play on the season and it threw the following error:

image

This left the client stuck in this state:

image

@cewert cewert requested a review from 1hitsong November 25, 2023 02:52
@1hitsong
Copy link
Member

The error above only occurs when I try to play an unwatched recording.

It's trying to use the IndexNumber property, but the item doesn't have that property.

    BackdropImageTags: <Component: roArray>
    ChannelId: invalid
    Container: "mpegts"
    Id: "865734ca38207d1a961733f8c321fa6e"
    ImageBlurHashes: <Component: roAssociativeArray>
    ImageTags: <Component: roAssociativeArray>
    IsFolder: false
    LocationType: "FileSystem"
    MediaType: "Video"
    Name: "2022 Field Hockey Championship: Virginia vs. North Carolina"
    ParentBackdropImageTags: <Component: roArray>
    ParentBackdropItemId: "3b4fc931bf2281e52243d2a198643de2"
    PremiereDate: "2023-10-19T00:00:00.0000000Z"
    ProductionYear: 2023
    RunTimeTicks: 542846656
    SeasonId: invalid
    SeasonName: "Season Unknown"
    SeriesId: "3b4fc931bf2281e52243d2a198643de2"
    SeriesName: "The Sixth Sense"
    SeriesPrimaryImageTag: "acacfbde1a129c9e92fa007cddd4c2ec"
    ServerId: "264f5f4ed7a8457c9fe28fbcc3769fb1"
    Type: "Episode"
    UserData: <Component: roAssociativeArray>
    VideoType: "VideoFile"
}`

@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Nov 30, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Nov 30, 2023
@cewert cewert force-pushed the fix-quickplay-libraries branch from ef6432c to a926d3c Compare November 30, 2023 03:12
@cewert cewert merged commit 03475c0 into jellyfin:unstable Nov 30, 2023
9 checks passed
@cewert cewert deleted the fix-quickplay-libraries branch November 30, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants