-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix movie and tv show library quickplay support #1531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error above only occurs when I try to play an unwatched recording. It's trying to use the IndexNumber property, but the item doesn't have that property.
|
1hitsong
approved these changes
Nov 30, 2023
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
cewert
force-pushed
the
fix-quickplay-libraries
branch
from
November 30, 2023 03:12
ef6432c
to
a926d3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently my local server is bugged because when I coded quick play, movie and tv show libraries came through as
collectionFolder
s but now they come through asuserView
s. This PR moves the quick play logic into a function and calls the fucntion from both paths.Tested and working with my local and the stable demo server (a buggy and non-buggy server)