Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Random sorting to supported libraries #1517

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Add Random sorting to supported libraries #1517

merged 1 commit into from
Dec 29, 2023

Conversation

1hitsong
Copy link
Member

Changes

Adds option to sort by Random to supported libraries. I found not all libraries support it, so I had to be selective.

Issues

Fixes #1498

@1hitsong 1hitsong requested a review from a team as a code owner November 19, 2023 22:32
@1hitsong 1hitsong added the feature A new feature that currently doesn't exist. label Nov 19, 2023
@jimdogx
Copy link
Contributor

jimdogx commented Dec 2, 2023

There does appear to be a bug with selecting sorting options, however, I can't see how it would have been introduced by this code. When I'm not seeing the bug, it works as expected 👍

@1hitsong
Copy link
Member Author

1hitsong commented Dec 2, 2023

There does appear to be a bug with selecting sorting options

What's the bug? Is there a ticket for it?

@jimdogx
Copy link
Contributor

jimdogx commented Dec 3, 2023

There does appear to be a bug with selecting sorting options

What's the bug? Is there a ticket for it?

The first time I select a sort option, it doesn't respect my choice and I have to go back in to the menu to re-select the option.
I'm not seeing a ticket for it. I need to see what the exact steps are and if it happens every time and then I can write a ticket for it. Again, no related to this PR though 😄

@jellyfin-bot jellyfin-bot added the merge-conflict This PR has a merge conflict label Dec 5, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks!

@cewert cewert changed the base branch from unstable to master December 14, 2023 15:07
@jellyfin-bot jellyfin-bot removed the merge-conflict This PR has a merge conflict label Dec 29, 2023
@1hitsong 1hitsong merged commit 7e3a234 into jellyfin:master Dec 29, 2023
11 checks passed
@1hitsong 1hitsong deleted the sortByRandom branch December 29, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimdogx jimdogx jimdogx approved these changes

Assignees
No one assigned
Labels
feature A new feature that currently doesn't exist.
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort library by Random
3 participants
@1hitsong @jimdogx @jellyfin-bot