Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return to OSD on dialog close #1516

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Return to OSD on dialog close #1516

merged 1 commit into from
Nov 19, 2023

Conversation

1hitsong
Copy link
Member

Changes

Ignore hide function if dialog is open. This causes the user to return to the OSD after dialog close.

Issues

Fixes #1504

@1hitsong 1hitsong requested a review from a team as a code owner November 19, 2023 00:46
cewert
cewert approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the screen would be too busy but the two dialogs "dim" the rest of the screen which works well 👍

@cewert cewert merged commit 7be954d into jellyfin:unstable Nov 19, 2023
9 checks passed
@1hitsong 1hitsong deleted the returnToPauseMenu branch November 19, 2023 17:41
@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cewert cewert cewert approved these changes

Assignees
No one assigned
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return to Pause Menu After Pause Menu Pop-Ups
2 participants
@1hitsong @cewert