Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked this down to a bad line of code I wrote in
migrations.bs
. It's trying to usem.global.session.server.id
but it will always be invalid at this point in the app when the function is called. We should just remove it instead of fixing it because what it's trying to do makes no sense anyway - the active server id is staying on the global "jellyfin" block and doesn't need to be migrated anywhere.One bad thing about brighterscript is that the lines shown on error logs are for the transpiled files and not the source files. I forgot this and couldn't figure out how line 18 in migrations (from the error tracestack) was writing to the reg but when I checked
build/staging/
the line number matched the right line of code:registry_write("serverId", m.global.session.server.id, savedUserId)