Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix photo regression, add photo support to home screen, and add quickplay photo support #1494

Merged
merged 10 commits into from
Nov 15, 2023
Merged

Fix photo regression, add photo support to home screen, and add quickplay photo support #1494

merged 10 commits into from
Nov 15, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Nov 12, 2023 •
edited
Loading

Changes

  • Fix photos not working from itemgrid (introduced by quickplay PR)
  • add support for photo libraries in "latest in" on the home page
  • support for opening a photo from the home page
    • photo will open by itself with no slideshow
  • support for opening a photoAlbum from the home page
    • all photos inside will open. slideshow will start if setting is turned on
  • Prevent double refresh() of home page on first load
  • Remove unneeded refresh check on home page
  • Support quickplay with type = photo
    • Open photo by itself
  • Support quickplay with type = photoAlbum
    • "Shuffle play" all photos inside. Use the API to randomize the order and start a slideshow
  • Support quickplay with photo libraries
    • "Shuffle play" all photos inside. Use the API to randomize the order and start a slideshow

NOTE: photos are still not supported by quickplay

@cewert cewert added the bug-fix This fixes a bug. label Nov 12, 2023
@cewert cewert requested a review from a team as a code owner November 12, 2023 01:27
@cewert cewert changed the title Fix bug with photos not working from itemgrid Fix photos not working from itemgrid Nov 12, 2023
jimdogx
jimdogx reviewed Nov 12, 2023
View reviewed changes
Copy link
Contributor

@jimdogx jimdogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Per our discussion, let's filter out Photos from "Latest In" (unless you have an epiphany to make it work). Having to go in to the Photo library to start a slideshow / view some pics isn't the end of the world and eventually we can change it to all be part of Quick Play like you suggested. 👍

@cewert
Copy link
Member Author

cewert commented Nov 14, 2023

Changes

  • add support for photo libraries in "latest in" on the home page
  • support for opening a photo from the home page
    • photo will open by itself with no slideshow
  • support for opening a photoAlbum from the home page
    • all photos inside will open. slideshow will start if setting is turned on
  • Prevent double refresh() of home page on first load
  • Remove unneeded refresh check

@cewert
Copy link
Member Author

cewert commented Nov 14, 2023 •
edited
Loading

Changes

  • Support quickplay with type = photo
    • Open photo by itself
  • Support quickplay with type = photoAlbum
    • "Shuffle play" all photos inside. Use the API to randomize the order and start a slideshow
  • Support quickplay with photo libraries
    • "Shuffle play" all photos inside. Use the API to randomize the order and start a slideshow

EDIT: This works from the home screen as well as itemgrid

@cewert cewert changed the title Fix photos not working from itemgrid Fix photo regression, add photo support to home screen, and add quickplay photo support Nov 14, 2023
@cewert cewert added feature A new feature that currently doesn't exist. and removed bug-fix This fixes a bug. labels Nov 14, 2023
@cewert cewert merged commit 6c759bc into jellyfin:unstable Nov 15, 2023
9 checks passed
@cewert cewert deleted the fix-photos-itemgrid branch November 15, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimdogx jimdogx jimdogx approved these changes

Assignees
No one assigned
Labels
feature A new feature that currently doesn't exist.
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cewert @jimdogx