Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress bar to pause menu #1491

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Add progress bar to pause menu #1491

merged 3 commits into from
Nov 12, 2023

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Nov 11, 2023

Changes

Adds a progress bar indicator to the pause menu showing the user their current position, time left in the video, and a visual percentage bar.

Demo

Pausemenuposition.mp4

@1hitsong 1hitsong requested a review from a team as a code owner November 11, 2023 22:32
Copy link
Contributor

@jimdogx jimdogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me 👍

@cewert cewert added the feature A new feature that currently doesn't exist. label Nov 12, 2023
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Timestamps and visuals are correct and I can't break it.

The only thing I don't like about the new bar is that the timestamps in the pause menu are smaller and in a different place than the ones in the rewind/ff trickplay bar. I know we were wanting them to look different so the user knows the pause menu bar isn't selectable but I found it a little jarring switching between the two menus because of this.

This is a bug I just found unrelated to this PR but it shows the two UIs next to each other:
PXL_20231112_034315849

to reproduce, hit left/right/rewind/ff while a video is playing then hit up or down and the pause menu will show up

@1hitsong
Copy link
Member Author

Styles slightly updated to match trickplay bar. Double bar bug fixed.

Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest commit lines up the progress bar with the trickplay bar and fixes the bug as advertised.

The only thing I noticed is that the trickplay bar uses leading zeros for the timestamps but our pause menu doesn't. We should probably make those match if it's not too much trouble.

@1hitsong
Copy link
Member Author

Leading minutes added.

@cewert cewert merged commit 1037fe0 into jellyfin:unstable Nov 12, 2023
9 checks passed
@1hitsong 1hitsong deleted the pauseMenuVideoPosition branch November 13, 2023 01:30
@cewert cewert mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature that currently doesn't exist.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants