Don't direct play opus audio files + transcode audio to AAC #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
changed the title
I did a deeper dive after I read this and according to my log, the reason the current stable version of the app is playing back my Opus music files is because it is converting them into AAC. Very interesting. Either way, this PR seems to make total sense as it's consistent with the functionality of current stable. |
1hitsong
approved these changes
Nov 5, 2023
cewert
added
ignore-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opus audio files are not supported by roku. This PR stops trying to direct play them and transcodes them instead to AAC.
This also fixes a bug with the new device profile where we were transcoding all audio to mp3. Now we are using aac for all 2 channel audio and mp3 for multichannel audio transcodes.
Changes
Issues
Fixes #1443