-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pause menu #1461
Create pause menu #1461
Conversation
Fixes #445
Wow. This looks awesome! Special points for include a A Nightmare on Elm Street Part 2 screenshot! |
The code looks good. Right now the next chapter buttons are called |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great. Nice job on this 👍
Changes
Creates a menu displayed when the user pauses playback of a video. The trickplay bar is no longer shown. This changes current behavior. The trickplay bar is still accessed by pressing left, right, rewind, or fast forward on the remote while the video is playing.
The menu has 3 buttons:
The menu is designed to handle more icons and functions in the future.
If user tries to go before chapter 1, it simply replays the chapter from the start. User can not go beyond last chapter, instruction is ignored.
Chapter names are used in the list, so if user has a chapter named "It's All Over" instead of "Chapter 1," "It's All Over" will be displayed.
If no chapter data is found, buttons are still displayed, but are inactive. Chapter list displays "No chapter data found" and is also inactive.
Issues
Fixes #445
Notes
This PR uses a param introduced in Roku OS 10, video.seekMode. This param is needed to make the chapter selection accurate.
Determining current chapter isn't perfect. We must compare Roku's video position param(seconds) to the chapter start time (ticks), so we must convert one of the numbers to the other format. The converted number drifts away from accuracy, especially late in movies when the values are at their highest. This can cause the current chapter lookup to be incorrect. As a result, late in a video a user may find they need to wait 2-3 seconds for the video position to advance past the chapter start value so they can skip to the next chapter. This issue can also cause the chapter list auto focus to be 1 chapter behind late in a movie.
Update. Adding a 15 second buffer to the current position fixed the issue I mentioned above. This fix is reflected in this PR.
Screenshot
Demo
https://social.linux.pizza/@tgpo/111327355574987355